Re: [PATCH] Add note that lockdep is not allowed with non-GPL modules

[Alexey Dobriyan <adobriyan@gmail.com>]

On Tue, Jul 04, 2006 at 10:29:04PM +0200, Petr Vandrovec wrote:
> Hi Ingo,
>   can you add this small notice to the lockdep option ?
>
> Lock dependency infrastructure forces all legacy code which uses lock to now
> depend on lockdep_init_map symbol, which is GPL-only.  It means that almost
> no modules can work on kernel with CONFIG_LOCKDEP set.  Let's warn user about
> that.

IANIngo, but the warning is already there:
* Proprietary module user probably already knows that major deviations from .config
  and kernel its module is released is no-no.
* Unknown symbol name contains "lockdep" which attentive proprietary
  module user will notice and correlate with enabling lockdep 5 minutes ago.
* Tomorrow Ingo will change it's name, add a couple of new lockdep only
  exports so should he update help text every time _he_ changes _his_
  code?
* Would you add similar notice to inotify help text? It also exports
  GPL-only symbols doncha know. Would you add such notices to everything
  exporting GPL-only symbols?

> vmmon: module license 'unspecified' taints kernel.
> vmmon: Unknown symbol lockdep_init_map

> +	 Do not enable this option if you are using non-GPL modules, or
> +	 they will fail to load due to missing symbol lockdep_init_map.

Lock validor found a bug in NVidia driver, film at 11.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/