Zach> Also, while looking at this I saw that the locks are being
Zach> re-initialized from mthca_modify_qp(). Is that just a
Zach> side-effect of relying on mthca_wq_init() to reset the
Zach> non-lock members? If you're concerned about
Zach> microoptimization it seems like this could be avoided.
I think that is actually a very minor bug you've found. If someone
were posting a work request at the same time as they transitioned a QP
to reset (which is a legitimate if not sensible thing to do), then the
spinlock could get reinitialized while it was held. Which would be
bad. So I think I like your original patch the best.
- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
