> On Wed, 21 Jun 2006 12:00:40 +0800
> Zang Roy-r61911 <[email protected]> wrote:
>
> > This patch adds a net device driver and configuration options for
> > Tundra Semiconductor Tsi108 integrated dual port Gigabit Ethernet
> > controller
>
> Your patch forgot to include these:
>
> > +#include <asm/tsi108_irq.h>
> > +#include <asm/tsi108.h>
>
> Why would a net driver have files in include/asm/?
The net driver is for a tsi108 on chip Ethernet controller. tsi108_irq provides the Ethernet IRQ number.
tsi108.h provides the hw_info structure. Now tsi108.h has been in the kernel tree. I'd like to provide
the tsi108_irq.h with tsi108 irq support in another patch. Any comment?
>
>
>
>
> Have some comments-via-diff, mainly trivial:
>
Thanks for your patch. It works OK! I will integrate it in my next version.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
