Re: [2.6 patch] i386: KEXEC must depend on (!SMP && X86_LOCAL_APIC)

[ebiederm@xmission.com (Eric W. Biederman)]

Adrian Bunk <bunk@stusta.de> writes:

> On Wed, Jun 28, 2006 at 11:35:15AM -0600, Eric W. Biederman wrote:
>> 
>> Adrian Bunk <bunk@stusta.de> writes:
>> > This patch fixes the following issue with CONFIG_SMP=y and 
>> > CONFIG_X86_VOYAGER=y:
>> >
>> > <--  snip  -->
>> >
>> > ...
>> >   CC      arch/i386/kernel/crash.o
>> > arch/i386/kernel/crash.c: In function ‘crash_nmi_callback’:
>> > arch/i386/kernel/crash.c:113: error: implicit declaration of function
>> > ‘disable_local_APIC’
>> >
>> > <--  snip  -->
>> 
>> I think the patch below more correctly captures the dependency.
>> 
>> In truth that call to disable_local_APIC() is a bug but the kernel
>> isn't ready yet to boot in apic only mode, so it remains until
>> the apic initialization can be moved into init_IRQ.
>> 
>> Does this sound good?
>
> It does compile (I can't test it due to lack of hardware).

The code that is disabled is really an optimization to get a higher
quality crash dump so we should be ok.

At the very least it should come very close to working for anyone on
that subarch.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/