Re: Unkillable process in last git -- Bisected

["Vladimir V. Saveliev" <vs@namesys.com>]

Hello

On Wed, 2006-06-28 at 20:38 +0200, Paolo Ornati wrote:
> > Running "localedef" triggers an infinite loop in kernel mode (or
> > something) --> localdef becomes unkillable.
> > 

Can you, please, run localedef under strace -e set=open,write on a
kernel having the below patch applied, so that we will see arguments of
write which caused write to fall into endless loop.


> commit 6527c2bdf1f833cc18e8f42bd97973d583e4aa83
> Author: Vladimir V. Saveliev <vs@namesys.com>
> Date:   Tue Jun 27 02:53:57 2006 -0700
> 
>     [PATCH] generic_file_buffered_write(): deadlock on vectored write
>     
>     generic_file_buffered_write() prefaults in user pages in order to avoid
>     deadlock on copying from the same page as write goes to.
>     
>     However, it looks like there is a problem when write is vectored:
>     fault_in_pages_readable brings in current segment or its part (maxlen).
>     OTOH, filemap_copy_from_user_iovec is called to copy number of bytes
>     (bytes) which may exceed current segment, so filemap_copy_from_user_iovec
>     switches to the next segment which is not brought in yet.  Pagefault is
>     generated.  That causes the deadlock if pagefault is for the same page
>     write goes to: page being written is locked and not uptodate, pagefault
>     will deadlock trying to lock locked page.
>     
>     [akpm@osdl.org: somewhat rewritten]
>     Cc: Neil Brown <neilb@suse.de>
>     Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
>     Cc: <stable@kernel.org>
>     Signed-off-by: Andrew Morton <akpm@osdl.org>
>     Signed-off-by: Linus Torvalds <torvalds@osdl.org>
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 9c7334b..d504d6e 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2095,14 +2095,21 @@ generic_file_buffered_write(struct kiocb
>  	do {
>  		unsigned long index;
>  		unsigned long offset;
> -		unsigned long maxlen;
>  		size_t copied;
>  
>  		offset = (pos & (PAGE_CACHE_SIZE -1)); /* Within page */
>  		index = pos >> PAGE_CACHE_SHIFT;
>  		bytes = PAGE_CACHE_SIZE - offset;
> -		if (bytes > count)
> -			bytes = count;
> +
> +		/* Limit the size of the copy to the caller's write size */
> +		bytes = min(bytes, count);
> +
> +		/*
> +		 * Limit the size of the copy to that of the current segment,
> +		 * because fault_in_pages_readable() doesn't know how to walk
> +		 * segments.
> +		 */
> +		bytes = min(bytes, cur_iov->iov_len - iov_base);
>  
>  		/*
>  		 * Bring in the user page that we will copy from _first_.
> @@ -2110,10 +2117,7 @@ generic_file_buffered_write(struct kiocb
>  		 * same page as we're writing to, without it being marked
>  		 * up-to-date.
>  		 */
> -		maxlen = cur_iov->iov_len - iov_base;
> -		if (maxlen > bytes)
> -			maxlen = bytes;
> -		fault_in_pages_readable(buf, maxlen);
> +		fault_in_pages_readable(buf, bytes);
>  
>  		page = __grab_cache_page(mapping,index,&cached_page,&lru_pvec);
>  		if (!page) {
> 
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/