[Patch] Missing statement in drivers/media/dvb/frontends/cx22700.c

hi,

stumbled over this because of coverity (id #492),
seems like we are missing a return statement here and fail
to do proper bounds checking. If this assumption is false
we should at least change the identation to make it clear

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c.orig	2006-06-28 01:40:49.000000000 +0200
+++ linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c	2006-06-28 01:41:04.000000000 +0200
@@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx227
 		return -EINVAL;
 
 	if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+		return -EINVAL;
 
 	if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
 		return -EINVAL;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: [patch 2/6] [Network namespace] Network device sharing by view
• Next by Date: Re: [Suspend2][ 0/9] Extents support.
• Previous by thread: 2.6.17-mm3 possible reiser4 bug
• Next by thread: [PATCH] oss/via: make bitfield unsigned
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]