At Tue, 27 Jun 2006 12:58:19 -0400,
Dave Jones wrote:
>
> On Tue, Jun 27, 2006 at 02:38:39PM +0200, Takashi Iwai wrote:
> > > > No, list_move() can't move the whole elements without loop.
> > > >
> > > > A solution is
> > > >
> > > > list_add(B, A);
> > > > list_del_init(A);
> > > >
> > > > (although this introduces a bit more code :)
> > >
> > > Shouldn't it be like this?
> > >
> > > ports_list_first = client->ports_list_head.next;
> > > list_del_init(client->ports_list_head);
> > > list_splice(ports_list_first, &deleted_list);
> >
> > This requires INIT_LIST_HEAD(&deleted_list) first, so obviously
> > a longer code :)
>
> This is hardly a speed/size critical function. I'd go for readability
> over cute hacks any day.
Yeah, of course.
The code was already fixed on ALSA tree to use standard macros.
Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
