Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

On Tue, 2006-06-27 at 00:02 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global mtdpart_setup() static.
> 
> Signed-off-by: Adrian Bunk <[email protected]>
> 
> --- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200
> +++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c     2006-06-26 23:18:51.000000000 +0200
> @@ -346,7 +346,7 @@
>   *
>   * This function needs to be visible for bootloaders.
>   */
> -int mtdpart_setup(char *s)
> +static int mtdpart_setup(char *s) 

Patch lacks sufficient explanation. Explain the relevance of the comment
immediately above the function declaration, in the context of your
patch. Explain your decision to change the behaviour, but not change the
comment itself.

Think. Or you will be replaced with a small shell script.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
  - From: Adrian Bunk <[email protected]>

References:
- [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
  - From: Adrian Bunk <[email protected]>

Prev by Date: Re: [Suspend2][ 15/20] [Suspend2] Attempt to freeze processes.
Next by Date: Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
Previous by thread: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
Next by thread: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]