Andrew Morton wrote:
> +x86_64-mm-ieee1394-early.patch
>
> x86_64 tree update
>From the patch:
|| Initialize ieee1394 early when built in
||
|| This makes debugging with firescope easier.
||
|| Cc: [email protected]
||
|| Signed-off-by: Andi Kleen <[email protected]>
...
|| +++ linux/drivers/ieee1394/ieee1394_core.c
...
|| +#ifndef MODULE
|| +fs_initcall(ieee1394_init);
|| +#else
|| module_init(ieee1394_init);
|| +#endif
...
|| +++ linux/drivers/ieee1394/ohci1394.c
...
|| +/* Try to register 1394 early to get the DMA engine running for
debugging purposes */
|| +#ifndef MODULE
|| +fs_initcall(ohci1394_init);
|| +#else
|| module_init(ohci1394_init);
|| +#endif
...
Perhaps it doesn't matter, but shouldn't it rather be a
subsys_initcall(ieee1394_init)?
[fs_initcall(ohci1394_init) instead of device_initcall(ohci1394_init) is
certainly appropriate if you want to have it up and running before other
device drivers.]
Also, I suggest an 80 columns friendly comment:
/* Register early. Useful for remote debugging via physical DMA */
--
Stefan Richter
-=====-=-==- -==- ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
