Re: [PATCH] fix idr locking in rtc class

On Mon, 26 Jun 2006 20:19:51 -0400
Sonny Rao <[email protected]> wrote:

 thanks for spotting this.
 Signed-off-by: Alessandro Zummo <[email protected]>

> We need to serialize access to the global rtc_idr even in this error path.
> 
> Signed-off-by: Sonny Rao <[email protected]>
> 
> --- linux-2.6.17/drivers/rtc/class.c~orig	2006-06-26 19:10:44.738511816 -0500
> +++ linux-2.6.17/drivers/rtc/class.c	2006-06-26 19:12:22.008724496 -0500
> @@ -93,7 +93,9 @@ exit_kfree:
>  	kfree(rtc);
>  
>  exit_idr:
> +	mutex_lock(&idr_lock);
>  	idr_remove(&rtc_idr, id);
> +	mutex_unlock(&idr_lock);
>  
>  exit:
>  	dev_err(dev, "rtc core: unable to register %s, err = %d\n",


-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fix idr locking in rtc class
    • From: Sonny Rao <[email protected]>

• Prev by Date: Re: GFS2 and DLM
• Next by Date: Re: [RFC][patch 1/4] Network namespaces: cleanup of dev_base list use
• Previous by thread: [PATCH] fix idr locking in rtc class
• Next by thread: [PATCH 00/24] V4L/DVB updates
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]