On 2006.06.26 23:08:57 +0200, Jean Delvare wrote:
> arch/i386/kernel/irq.c: In function `do_IRQ':
> arch/i386/kernel/irq.c:104: warning: suggest parentheses around arithmetic in operand of |
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Björn Steinbrink <[email protected]>
> Cc: Arjan van de Ven <[email protected]>
> ---
> arch/i386/kernel/irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.17-git.orig/arch/i386/kernel/irq.c 2006-06-26 21:55:03.000000000 +0200
> +++ linux-2.6.17-git/arch/i386/kernel/irq.c 2006-06-26 22:54:49.000000000 +0200
> @@ -100,8 +100,8 @@
> * softirq checks work in the hardirq context.
> */
> irqctx->tinfo.preempt_count =
> - irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK |
> - curctx->tinfo.preempt_count & SOFTIRQ_MASK;
> + (irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK) |
> + (curctx->tinfo.preempt_count & SOFTIRQ_MASK);
>
> asm volatile(
> " xchgl %%ebx,%%esp \n"
Hi,
thanks for catching that one, I even fixed that on the box where the
patch was tested but then obviously sent the old patch.
Acked-by: Björn Steinbrink <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
