* Christoph Hellwig <[email protected]> wrote:
> > The part where you needed file_read_actor looks like pretty much a stright
> > cut and paste from __generic_file_aio_read, which indicates that you might
> > be exporting at the wrong level.
>
> A definitive NACK to this export. All other filesystems manage to use
> the generic file read code so GFS should do so aswell. And there's a
> technical reason for not exporting aswell as the generic file read
> interface is far too complicated already.
GFS is different here mostly due to locking, because one of its strong
features is an implementation of pretty strict POSIX semantics in a
clustered environment, something that no other Linux FS (that is
available in source code) has done so far. (OCFS2 does not do it as
strictly - it has a very specific application in mind)
so i'd reformulate your request as a request to extend the VFS to unify
clustering filesystems - which is a nice cleanup goal but not a merge
showstopper to me.
> > Not sure about the tty_ export. Would it be better to make a generic
> > printfish interface on top of it and also replace the interesting
> > dquot.c gymnastics? (I don't know)
>
> In fact neither gfs nor dquot should use it at all. The xfs quota
> code is fine without this nonsense.
yeah, the tty_ export is unnecessary and should be fixed. But this seems
quite easy to do.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
