[PATCH -rt] fix preempt hardirqs on OMAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This should fix hardirq threading when the chained handler
disables an interrupt when setting IRQ_PENDING. Which happens
on OMAP, but I'm not sure how many other ARM boards do this.
It also has the effect of re-running the interrupt on 
IRQ_PENDING, which would normally be handled inside the chained
handler. Since this happens inside a thread the chained handler
will just wake up the thread multiple times, leaving the thread
to actually rerun the interrupt .

Signed-Off-By: Daniel Walker <[email protected]>

---
 kernel/irq/manage.c |   13 +++++++++++++
 1 files changed, 13 insertions(+)

Index: linux-2.6.16/kernel/irq/manage.c
===================================================================
--- linux-2.6.16.orig/kernel/irq/manage.c
+++ linux-2.6.16/kernel/irq/manage.c
@@ -511,6 +511,7 @@ static void thread_simple_irq(irq_desc_t
 	unsigned int irq = desc - irq_desc;
 	irqreturn_t action_ret;
 
+restart:
 	if (action && !desc->depth) {
 		spin_unlock(&desc->lock);
 		action_ret = handle_IRQ_event(irq, NULL, action);
@@ -520,6 +521,18 @@ static void thread_simple_irq(irq_desc_t
 		if (!noirqdebug)
 			note_interrupt(irq, desc, action_ret, NULL);
 	}
+
+	/*
+	 * Some boards will disable an interrupt when it
+	 * sets IRQ_PENDING . So we have to remove the flag
+	 * and re-enable to handle it.
+	 */
+	if (desc->status & IRQ_PENDING) {
+		desc->status &= ~IRQ_PENDING;
+		if (desc->chip)
+			desc->chip->enable(irq);
+		goto restart;
+	}
 	desc->status &= ~IRQ_INPROGRESS;
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux