On Mon, Jun 26, 2006 at 11:38:35AM -0400, Dave Jones wrote:
> On Mon, Jun 26, 2006 at 05:10:12PM +0200, Adrian Bunk wrote:
> > virt_to_bus/bus_to_virt are long deprecated, mark them as __deprecated
> > on i386.
> >
> > Without such warnings people will never update their code and fix
> > the errors in PPC64 builds.
>
> .. and deprecating pm_send_all, cli, sti, restore_flags, check_region yadayada
> has really been a great success at motivating people to fix those up too.
It has been a success, look at the numbers:
2.6.0 : 36 options depending on BROKEN_ON_SMP
2.6.17-mm2: 17 options depending on BROKEN_ON_SMP
2.6.7-mm7 : 20 drivers with warnings due to check_region
2.6.17-mm2: 3 drivers with warnings due to check_region
It's not that everything was fixed immediately, but there is definitely
some progress.
> How about we fix up some of the existing noise before we add more?
> A build log of a fedora kernel I had handy shows 165 deprecated warnings
> that have been there forever. Your proposal will add over 500 warnings
> in drivers/ alone.
There are few drivers generating many warnings, e.g. stallion+istallion
alone give 138 __deprecated warnings only for cli/sti/restore_flags
usage. Most of the code doesn't have any problems.
And my main motivation for getting virt_to_bus/bus_to_virt removed is
the following:
If the virt_to_bus/bus_to_virt are fixed, Andrew might finally accept my
patch to add -Werror-implicit-function-declaration to the CFLAGS (which
he only rejected since it turned link errors into compile errors in his
ppc64 builds).
And -Werror-implicit-function-declaration is important since it will
turn some nasty to debug runtime stack corruptions into compile errors.
> Dave
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
