Re: [patch 61/61] lock validator: enable lock validator in Kconfig

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Fri, 23 Jun 2006, Ingo Molnar wrote:

> > Could you please keep all the defaults in a separate -mm-only patch, 
> > so it doesn't get merged?
> 
> yep - the default got removed.

Thanks.

> > > +config LOCKDEP
> > > +	bool
> > > +	default y
> > > +	depends on PROVE_SPIN_LOCKING || PROVE_RW_LOCKING || PROVE_MUTEX_LOCKING || PROVE_RWSEM_LOCKING
> > 
> > This can be written shorter as:
> > 
> > config LOCKDEP
> > 	def_bool PROVE_SPIN_LOCKING || PROVE_RW_LOCKING || PROVE_MUTEX_LOCKING || PROVE_RWSEM_LOCKING
> 
> ok, done. (Btw., there's tons of other Kconfig code though that uses the 
> bool + depends syntax though, and def_bool usage is quite rare.)

The new syntax was added later, so everything that was converted uses the 
basic syntax and is still copied around a lot (where it's probably also 
doesn't help that it's not properly documented yet). I'm still planing to 
go through this and convert most of them...

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/