I wrote: ...
@@ -2864,25 +2877,23 @@ static int raw1394_release(struct inode
...
+ /* Sleep until more requests can be freed. + * FIXME? This sleeps uninterruptibly. */ + wait_event(fi->wait_complete, (req = next_complete_req(fi))); + free_pending_request(req);
We certainly cannot allow anybody to close the file with pending or orphaned complete requests, so maybe I should white-out that FIXME.
-- Stefan Richter -=====-=-==- -==- ==--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [RFC PATCH 2.6.17-mm1 1/3] ieee1394: reduce size of hpsb_host by 252 bytes
- From: Stefan Richter <[email protected]>
- [RFC PATCH 2.6.17-mm1 2/3] ieee1394: coarser locking for tlabel allocation
- From: Stefan Richter <[email protected]>
- [RFC PATCH 2.6.17-mm1 3/3] ieee1394: nodemgr: read tlabel attributes atomically
- From: Stefan Richter <[email protected]>
- [RFC PATCH 2.6.17-mm1 4/3] ieee1394: convert ieee1394_transactions from semaphores to waitqueue
- From: Stefan Richter <[email protected]>
- Re: [RFC PATCH 2.6.17-mm1 4/3] ieee1394: convert ieee1394_transactions from semaphores to waitqueue
- From: Stefan Richter <[email protected]>
- Re: [RFC PATCH 2.6.17-mm1 4/3] ieee1394: convert ieee1394_transactions from semaphores to waitqueue
- From: Arjan van de Ven <[email protected]>
- [RFC PATCH 2.6.17-mm1 5/3] ieee1394: raw1394: remove redundant counting semaphore
- From: Stefan Richter <[email protected]>
- [RFC PATCH 2.6.17-mm1 1/3] ieee1394: reduce size of hpsb_host by 252 bytes
- Prev by Date: Re: Problem with 2.6.17-mm2
- Next by Date: 2.6.17-mm2 -- drivers/built-in.o: In function `is_pci_dock_device':acpiphp_glue.c:(.text+0x12364): undefined reference to `is_dock_device'
- Previous by thread: [RFC PATCH 2.6.17-mm1 5/3] ieee1394: raw1394: remove redundant counting semaphore
- Next by thread: Re: [RFC PATCH 2.6.17-mm1 4/3] ieee1394: convert ieee1394_transactions from semaphores to waitqueue
- Index(es):
 |