Re: [PATCH] ieee1394: dv1394: sem2mutex conversion

On Sat, 2006-06-24 at 19:37 +0200, Stefan Richter wrote:
> 
> -               if (down_trylock(&video->sem)) {
> +               if (mutex_trylock(&video->mtx)) {

this is a bug!

mutex_trylock follows the spinlock trylock convention, not the semaphore
trylock convention!!!


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] ieee1394: dv1394: sem2mutex conversion
    • From: Stefan Richter <[email protected]>

• References:
  • [PATCH] ieee1394: dv1394: sem2mutex conversion
    • From: Stefan Richter <[email protected]>

• Prev by Date: Re: 2.6.17-...: looong writeouts
• Next by Date: Re: [RFC PATCH 2.6.17-mm1 4/3] ieee1394: convert ieee1394_transactions from semaphores to waitqueue
• Previous by thread: [PATCH] ieee1394: dv1394: sem2mutex conversion
• Next by thread: Re: [PATCH] ieee1394: dv1394: sem2mutex conversion
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]