Re: [PATCH]: e1000: Janitor: Use #defined values for literals

On Fri, Jun 23, 2006 at 01:07:21PM -0700, Auke Kok wrote:
> Linas Vepstas wrote:
> >Minor janitorial patch: use #defines for literal values.
> >
> >-	pci_enable_wake(pdev, 3, 0);
> >-	pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */
> >+	pci_enable_wake(pdev, PCI_D3hot, 0);
> >+	pci_enable_wake(pdev, PCI_D3cold, 0);
> > 
> I Acked this but that's silly - the patches sent yesterday already change 
> the code above and this patch is no longer needed (thanks Jesse for 
> spotting this).
> 
> This patch would conflict with them so please don't apply.

Oh, OK, I didn't see the patches sent yesterday, I tripped over this
on an unrelated code walk.

--linas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH]: e1000: Janitor: Use #defined values for literals
    • From: [email protected] (Linas Vepstas)
  • Re: [PATCH]: e1000: Janitor: Use #defined values for literals
    • From: Auke Kok <[email protected]>

• Prev by Date: [PATCH] add receive_room flow control to flush_to_ldisc
• Next by Date: RE: [PATCH] Add MCP65 support for sata_nv driver
• Previous by thread: Re: [PATCH]: e1000: Janitor: Use #defined values for literals
• Next by thread: Re: [PATCH]: e1000: Janitor: Use #defined values for literals
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]