* Andrew Morton <[email protected]> wrote:
> On Mon, 29 May 2006 23:25:23 +0200
> Ingo Molnar <[email protected]> wrote:
>
> > +# define spin_lock_init_key(lock, key) \
> > + __spin_lock_init((lock), #lock, key)
>
> erk. This adds a whole new layer of obfuscation on top of the
> existing spinlock header files. You already need to run the
> preprocessor and disassembler to even work out which flavour you're
> presently using.
>
> Ho hum.
agreed. I think the API we started using in latest -mm
(lockdep_init_key()) is the cleaner approach - that also makes it
trivially sure that lockdep doesnt impact non-lockdep code. I'll fix the
current lockdep_init_key() shortcomings and i'll get rid of the
*_init_key() APIs.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
