On Fri, 23 Jun 2006 00:16:22 +0200, Alessandro Zummo <[email protected]> wrote:
> > Add RTC drivers for the Dallas DS1553 and DS1742 RTC chip.
> >
> > Signed-off-by: Atsushi Nemoto <[email protected]>
>
> please split this into two patches.
OK, I'll send two patches soon.
> on which systems will we likely find those twos? no extra
> depends?
MIPS, PPC, ARM, etc. I think no extra depends needed.
> > +static int ds1553_rtc_ioctl(struct device *dev, unsigned int cmd,
> > + unsigned long arg)
> > +{
> > + struct platform_device *pdev = to_platform_device(dev);
> > + struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
> > +
> > + if (pdata->irq < 0)
> > + return -ENOIOCTLCMD;
>
> inappropriate -Exxx . maybe -ENODEV?.
No, it is intentional. If irq is not available, I want to fall back
into emulation in rtc-dev.c.
Thanks for your comments.
---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
