Re: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver

[Atsushi Nemoto <anemo@mba.ocn.ne.jp>]

On Fri, 23 Jun 2006 00:16:22 +0200, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> > Add RTC drivers for the Dallas DS1553 and DS1742 RTC chip.
> > 
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
>  please split this into two patches.

OK, I'll send two patches soon.

>  on which systems will we likely find those twos? no extra
>  depends?

MIPS, PPC, ARM, etc.  I think no extra depends needed.

> > +static int ds1553_rtc_ioctl(struct device *dev, unsigned int cmd,
> > +			    unsigned long arg)
> > +{
> > +	struct platform_device *pdev = to_platform_device(dev);
> > +	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
> > +
> > +	if (pdata->irq < 0)
> > +		return -ENOIOCTLCMD;
> 
>  inappropriate -Exxx . maybe -ENODEV?.

No, it is intentional.  If irq is not available, I want to fall back
into emulation in rtc-dev.c.

Thanks for your comments.
---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/