Re: [PATCH -mm 6/6] cpu_relax(): ptrace.c coding style fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



> Fix existing cpu_relax() loop to have proper kernel style.

..but you change the code, not its style.

> @@ -182,9 +182,8 @@
>  	if (!write_trylock(&tasklist_lock)) {
>  		local_irq_enable();
>  		task_unlock(task);
> -		do {
> +		while (!write_can_lock(&tasklist_lock))
>  			cpu_relax();
> -		} while (!write_can_lock(&tasklist_lock));
>  		goto repeat;
>  	}

I guess that barrier was needed before write_can_lock can succeed.
=> your version does one unneccessary test.

64 bytes from icmp_seq=28 ttl=51 time=448769.1 ms         

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at
Please read the FAQ at

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux