Re: [v4l-dvb-maintainer] [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Predrag Ivanovic wrote:
Hi.
Trivial patch, really.
Fixes include line in bttvp.h(btcx-risc.h is in parent dir).
------
--- bttvp.h	2006-06-19 16:48:46.000000000 +0200
+++ bttvp.h.new	2006-06-19 16:49:54.000000000 +0200
@@ -48,7 +48,7 @@
#include "bt848.h"
 #include "bttv.h"
-#include "btcx-risc.h"
+#include "../btcx-risc.h"
#ifdef __KERNEL__ ----------- Pedja
NACK.

Please see drivers/media/video/bt8xx/Makefile

You will notice the following line:

EXTRA_CFLAGS += -Idrivers/media/video

This instructs the compiler to find some other required headers in drivers/media/video (such as btcx-risc.h)

Your patch is unnecessary, and it is bad practice to use ".." inside a header includes path, IMHO at least.

In addition, please see the guidelines in Documentation/SubmittingPatches before you send any future patches. We cannot accept patches into the linux kernel without a proper developer's certificate of origin.

Thank you for the effort, though :-)

Regards,

Michael Krufky


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux