Re: Memory corruption in 8390.c ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ar Mer, 2006-06-21 am 10:23 -0700, ysgrifennodd Ben Pfaff:
> > +		memset(buf, 0, ETH_ZLEN);	/* more efficient than doing just the needed bits */
> > +		memcpy(buf, data, ETH_ZLEN);
> 
> Is this really correct?  It zeros out ETH_ZLEN bytes only to
> immediately copy over all of them again.

When I did it originally I tested with rdtsc and its actually quicker to
let it build the static memset the copy data over it than to do the
extra maths and the variable length loop.

Hence the comment


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux