Re: [PATCH 2/12] Support for larger maximum key size

On Wed, Jun 21, 2006 at 09:49:57AM -0500, Timothy R. Chavez wrote:
> > -		    ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES;
> > -	for (i = 0; i < auth_tok->session_key.encrypted_key_size; i++)
> > +	for (i = 0; i < (crypt_stat->key_size_bits / 8); i++)
> 
> Why don't you just do this particular calculation once?  Just looking
> down, you do this same calculation at least 4 other potential times.

Patch #10 in this set changes the keysize to bytes, so this is a
resolved issue.

Thanks,
Mike

Attachment: signature.asc
Description: Digital signature

---

• References:
  • [PATCH 2/12] Support for larger maximum key size
    • From: Mike Halcrow <[email protected]>
  • Re: [PATCH 2/12] Support for larger maximum key size
    • From: "Timothy R. Chavez" <[email protected]>

• Prev by Date: Re: realtime-preempt for MIPS - compile problem with rwsem
• Next by Date: Re: Why can't I set the priority of softirq-hrt? (Re: 2.6.17-rt1)
• Previous by thread: Re: [PATCH 2/12] Support for larger maximum key size
• Next by thread: [PATCH 3/12] Add codes for additional ciphers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]