Re: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private

[Jan Engelhardt <jengelh@linux01.gwdg.de>]

>--- linux-2.6.17.orig/fs/jffs/inode-v23.c	2006-06-18 18:58:51.000000000 -0400
>+++ linux-2.6.17/fs/jffs/inode-v23.c	2006-06-18 18:58:55.000000000 -0400
>@@ -369,7 +369,7 @@
> 
> 	f = jffs_find_file(c, raw_inode->ino);
> 
>-	inode->u.generic_ip = (void *)f;
>+	inode->i_private = (void *)f;
> 	insert_inode_hash(inode);
> 
> 	return inode;

struct jffs_file *                                                              
jffs_find_file(struct jffs_control *c, __u32 ino)
Cast not required.

>@@ -739,7 +739,7 @@
> 	unsigned long read_len;
> 	int result;
> 	struct inode *inode = (struct inode*)page->mapping->host;
>-	struct jffs_file *f = (struct jffs_file *)inode->u.generic_ip;
>+	struct jffs_file *f = (struct jffs_file *)inode->i_private;
> 	struct jffs_control *c = (struct jffs_control *)inode->i_sb->s_fs_info;
> 	int r;
> 	loff_t offset;

Same.

>--- linux-2.6.17.orig/fs/inode.c	2006-06-18 18:58:51.000000000 -0400
>+++ linux-2.6.17/fs/inode.c	2006-06-18 18:58:55.000000000 -0400
>@@ -164,7 +164,7 @@
> 				bdi = sb->s_bdev->bd_inode->i_mapping->backing_dev_info;
> 			mapping->backing_dev_info = bdi;
> 		}
>-		memset(&inode->u, 0, sizeof(inode->u));
>+		inode->i_private = 0;

inode->i_private = NULL;


Looks good!


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/