On Mon, 19 Jun 2006 19:34:28 +0200
Frank Gevaerts <[email protected]> wrote:
| On Mon, Jun 19, 2006 at 01:42:40PM -0300, Luiz Fernando N. Capitulino wrote:
| > On Mon, 19 Jun 2006 10:46:19 +0200
| > Frank Gevaerts <[email protected]> wrote:
| >
| > | Adds configurable waiting periods to the ipaq connection code. These are
| > | not needed when the pocketpc device is running normally when plugged in,
| > | but they need extra delays if they are physically connected while
| > | rebooting.
| > | There are two parameters :
| > | * initial_wait : this is the delay before the driver attemts to start the
| > | connection. This is needed because the pocktpc device takes much
| > | longer to boot if the driver starts sending control packets too soon.
| > | * connect_retries : this is the number of times the control urb is
| > | retried before finally giving up. The patch also adds a 1 second delay
| > | between retries.
| > | I'm not sure if the cases where this patch is useful are general enough
| > | to include this in the kernel.
| > |
| > | Signed-off-by: Frank Gevaerts <[email protected]>
| > |
| > | diff -urp linux-2.6.17-rc6.a/drivers/usb/serial/ipaq.c linux-2.6.17-rc6.b/drivers/usb/serial/ipaq.c
| > | --- linux-2.6.17-rc6.a/drivers/usb/serial/ipaq.c 2006-06-14 16:02:03.000000000 +0200
| > | +++ linux-2.6.17-rc6.b/drivers/usb/serial/ipaq.c 2006-06-14 16:06:44.000000000 +0200
| > | @@ -71,6 +71,8 @@
| > |
| > | static __u16 product, vendor;
| > | static int debug;
| > | +static int connect_retries = KP_RETRIES;
| > | +static int initial_wait;
| > |
| > | /* Function prototypes for an ipaq */
| > | static int ipaq_open (struct usb_serial_port *port, struct file *filp);
| > | @@ -583,7 +585,7 @@ static int ipaq_open(struct usb_serial_p
| > | struct ipaq_private *priv;
| > | struct ipaq_packet *pkt;
| > | int i, result = 0;
| > | - int retries = KP_RETRIES;
| > | + int retries = connect_retries;
| > |
| > | dbg("%s - port %d", __FUNCTION__, port->number);
| > |
| > | @@ -647,6 +649,7 @@ static int ipaq_open(struct usb_serial_p
| > | port->read_urb->transfer_buffer_length = URBDATA_SIZE;
| > | port->bulk_out_size = port->write_urb->transfer_buffer_length = URBDATA_SIZE;
| > |
| > | + msleep(1000*initial_wait);
| >
| > I was going to say you should use ssleep() here, but I can't find a
| > ssleep_interruptible(). Then either: use msleep_interruptible() or
| > creates a new ssleep_interruptible().
|
| I wasn't sure if that was safe here, so I used the non-interruptible
| version. I'll change it when I redo the patch.
| Is it worth it creating ssleep_interruptible() just for this one call?
You could grep around to check it.
--
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
