Re: [RFC] [PATCH 4/8] inode-diet: Move i_cdev into a union

>===================================================================
>--- linux-2.6.17.orig/fs/file_table.c	2006-06-18 19:37:14.000000000 -0400
>+++ linux-2.6.17/fs/file_table.c	2006-06-18 19:50:56.000000000 -0400
>@@ -170,7 +170,7 @@
> 	if (file->f_op && file->f_op->release)
> 		file->f_op->release(inode, file);
> 	security_file_free(file);
>-	if (unlikely(inode->i_cdev != NULL))
>+	if (unlikely(S_ISCHR(inode->i_mode) && (inode->i_cdev != NULL)))

Am I allowed to be nitpicky? If so, drop the () around inode->i_cdev != 
NULL. :)



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC] [PATCH 0/8] Inode slimming
    • From: Theodore Tso <[email protected]>
  • [RFC] [PATCH 4/8] inode-diet: Move i_cdev into a union
    • From: Theodore Tso <[email protected]>

• Prev by Date: Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default
• Next by Date: Re: [ck] 2.6.17-ck1
• Previous by thread: [RFC] [PATCH 4/8] inode-diet: Move i_cdev into a union
• Next by thread: [RFC] [PATCH 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]