Re: [RFC] [patch 3/6] [Network namespace] Network devices isolation

On Fri, Jun 09, 2006 at 11:02:05PM +0200, [email protected] wrote:
>  struct net_device *dev_get_by_name(const char *name)
>  {
> +	struct net_ns_dev_list *dev_list = &(net_ns()->dev_list);
>  	struct net_device *dev;
>  
> -	read_lock(&dev_base_lock);
> +	read_lock(&dev_list->lock);
>  	dev = __dev_get_by_name(name);
>  	if (dev)
>  		dev_hold(dev);
> -	read_unlock(&dev_base_lock);
> +	read_unlock(&dev_list->lock);
>  	return dev;

And what would stop renames done via different lists from creating a
conflict?  Incidentally, WTF protects the device name while we are
doing that lookup?

While we are at it, what are you going to do with sysfs?
ls /sys/class/net and watch the fun...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC] [patch 0/6] [Network namespace] introduction
    • From: [email protected]
  • [RFC] [patch 3/6] [Network namespace] Network devices isolation
    • From: [email protected]

• Prev by Date: Re: [RFC] [patch 2/6] [Network namespace] Network device sharing by view
• Next by Date: 2.6.17-rc6-mm2 VIA PATA fails on some ATAPI drives
• Previous by thread: [RFC] [patch 3/6] [Network namespace] Network devices isolation
• Next by thread: [RFC] [patch 6/6] [Network namespace] Network namespace debugfs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]