Re: [PATCH] affs_fill_super() %s abuses

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Thu, 15 Jun 2006, Al Viro wrote:

> @@ -420,11 +422,17 @@ got_root:
>  	}
>  
>  	if (mount_flags & SF_VERBOSE) {
> -		chksum = cpu_to_be32(chksum);
> -		printk(KERN_NOTICE "AFFS: Mounting volume \"%*s\": Type=%.3s\\%c, Blocksize=%d\n",
> -			AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0],
> -			AFFS_ROOT_TAIL(sb, root_bh)->disk_name + 1,
> -			(char *)&chksum,((char *)&chksum)[3] + '0',blocksize);
> +		int len = AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0];
> +		char name[32];
> +
> +		if (len > 31)
> +			len = 31;

You get the same effect by changing it above into "min(AFFS_ROOT_TAIL(sb, 
root_bh)->disk_name[0], 31)" and makes the copying unnecessary.
BTW since this is only active with SF_VERBOSE, I don't think it's critical 
enough for 2.6.17 at this point.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/