On Wed, 14 Jun 2006 13:58:22 +0200
Frank Gevaerts <[email protected]> wrote:
| On Thu, Jun 01, 2006 at 09:18:40PM +0200, Frank Gevaerts wrote:
| > On Wed, May 31, 2006 at 03:46:24PM -0700, Greg KH wrote:
| > > This is not how you pre-initialize a module parameter...
| >
| > Thanks. That should teach me not to try to fix kernel code without
| > reading documentation. I fixed it here, but I won't resubmit yet because
| > there are some 100% reproducible bugs left.
|
| Everything now runs for more than a week without problems, so I guess I
| now have all bugs. I have split out the extra parameters to a separate
| patch, because they might not be needed for the standard kernel.
| The fixes to usb-serial.c (in a separate mail/thread) are also needed
| for bug-free operation.
|
|
| This patch fixes several problems in the ipaq.c driver with connecting
| and disconnecting pocketpc devices:
| * The read urb stayed active if the connect failed, causing nullpointer
| dereferences later on.
| * If a write failed, the driver continued as if nothing happened. Now it
| handles that case the same way as other usb serial devices (fix by
| "Luiz Fernando N. Capitulino" <[email protected]>)
|
| Signed-off-by: Frank Gevaerts <[email protected]>
|
| diff -urp linux-2.6.17-rc6/drivers/usb/serial/ipaq.c linux-2.6.17-rc6.a/drivers/usb/serial/ipaq.c
| --- linux-2.6.17-rc6/drivers/usb/serial/ipaq.c 2006-03-20 06:53:29.000000000 +0100
| +++ linux-2.6.17-rc6.a/drivers/usb/serial/ipaq.c 2006-06-14 13:22:57.000000000 +0200
| @@ -652,7 +652,6 @@ static int ipaq_open(struct usb_serial_p
| usb_rcvbulkpipe(serial->dev, port->bulk_in_endpointAddress),
| port->read_urb->transfer_buffer, port->read_urb->transfer_buffer_length,
| ipaq_read_bulk_callback, port);
| - result = usb_submit_urb(port->read_urb, GFP_KERNEL);
| if (result) {
| err("%s - failed submitting read urb, error %d", __FUNCTION__, result);
| goto error;
| @@ -671,6 +670,7 @@ static int ipaq_open(struct usb_serial_p
| usb_sndctrlpipe(serial->dev, 0), 0x22, 0x21,
| 0x1, 0, NULL, 0, 100);
| if (result == 0) {
| + result = usb_submit_urb(port->read_urb, GFP_KERNEL);
| return 0;
| }
| }
I think you forgot to move the 'result' checking after the urb is
submitted.
--
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
