Re: [PATCH 07/11] Task watchers: Register per-task delay accounting task watcher

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






Matt Helsley wrote:

Adapts delayacct to use Task Watchers. Does not adapt taskstats to use Task
Watchers.

Signed-off-by: Matt Helsley <[email protected]>
Cc: Shailabh Nagar <[email protected]>
Cc: Balbir Singh <[email protected]>
Cc: Chandra S. Seetharaman <[email protected]>
--

include/linux/delayacct.h |    2 +-
kernel/delayacct.c        |   23 +++++++++++++++++++++++
kernel/exit.c             |    2 --
kernel/fork.c             |    2 --
4 files changed, 24 insertions(+), 5 deletions(-)


<snip>

Index: linux-2.6.17-rc5-mm2/include/linux/delayacct.h
===================================================================
--- linux-2.6.17-rc5-mm2.orig/include/linux/delayacct.h
+++ linux-2.6.17-rc5-mm2/include/linux/delayacct.h
@@ -59,11 +59,11 @@ static inline void delayacct_tsk_init(st
		__delayacct_tsk_init(tsk);
}

static inline void delayacct_tsk_exit(struct task_struct *tsk)
{
-	if (tsk->delays)
+	if (unlikely(tsk->delays))
		__delayacct_tsk_exit(tsk);
}

This snippet does not belong to this patchset...since the same check (for tsk->delays) is being used elsewhere in the delay accounting code, changes to use of likely/unlikely should
be done elsewhere too, if deemed necesssary.

Otherwise patch looks good though I've not tested whether delay accounting works unaffected
(don't see any reason why it shouldn't).


--Shailabh


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux