Re: [PATCH 03/11] Task watchers: Refactor process events

On Tue, 2006-06-13 at 19:43 -0500, Chase Venters wrote:
> On Tuesday 13 June 2006 18:54, Matt Helsley wrote:
> 
> > +	WARN_ON((which_id != PROC_EVENT_UID) && (which_id != PROC_EVENT_GID));
> >  }
> 
> How about WARN_ON(!(which_id & (PROC_EVENT_UID | PROC_EVENT_GID))) to save a 
> cmp?
> 
> Thanks,
> Chase

I think the compiler is capable of making such optimizations. I also
think what I have now is clearer to anyone skimming the code.

Cheers,
	-Matt Helsley

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 03/11] Task watchers: Refactor process events
    • From: Chase Venters <[email protected]>

• References:
  • [PATCH 03/11] Task watchers: Refactor process events
    • From: Matt Helsley <[email protected]>
  • Re: [PATCH 03/11] Task watchers: Refactor process events
    • From: Chase Venters <[email protected]>

• Prev by Date: [RFC] Use ZVCs for numa statistics.
• Next by Date: Re: zoned vm counters: per zone counter functionality
• Previous by thread: Re: [PATCH 03/11] Task watchers: Refactor process events
• Next by thread: Re: [PATCH 03/11] Task watchers: Refactor process events
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]