Re: [PATCH 2.6.17-rc6 7/9] Remove some of the kmemleak false positives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/06, Pekka J Enberg <[email protected]> wrote:
On 12/06/06, Pekka Enberg <[email protected]> wrote:
> > Can we fix this by looking for pointers to anywhere in the allocated
> > memory block instead of just looking for the start?

On Mon, 12 Jun 2006, Catalin Marinas wrote:
> I thought about this as well (I think that's how Valgrind works) but
> it would increase the chances of missing real leaks.

Yeah but that's far better than adding bunch of 'not a leak' annotations
around the kernel which is very impractical to maintain.  I would like to
see your leak detector in the kernel so we can finally get rid of all
those per-subsystem magic allocators.  This patch, however, is
unacceptable for inclusion IMHO.

My initial hope was that simply tweaking the container_of macro would
be enough to get the inside-block pointers (or, at least, modify some
key places like net/core/dev.c) but it looks like it wasn't and I
introduced the memleak_not_leak() function which had to be added to
some individual drivers as well.

As I said, I'll do some tests first because looking at all the
locations inside a block might make the tool less useful.

--
Catalin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux