> >
> > Not sure how serious this is; the driver seems to work fine later on.
>
> Doesn't look serious. init_module() is not __init, but it calls
> some __init functions and touches some __initdata.
This is the typical case with inconsistent tagging.
> BTW, I would be happy to see some consistent results from modpost
> section checking. I don't see all of these warnings (I see only 1)
> when using gcc 3.3.6. What gcc version are you using?
> Does that matter? (not directed at anyone in particular)
I did not see anyone of them - strange.
I did not dig into it, but objdump -rR ne.o should tell the number of
mismatches with soem carefull checking.
> --- linux-2617-rc6.orig/drivers/net/ne.c
> +++ linux-2617-rc6/drivers/net/ne.c
> @@ -829,7 +829,7 @@ that the ne2k probe is the last 8390 bas
> is at boot) and so the probe will get confused by any other 8390 cards.
> ISA device autoprobes on a running machine are not recommended anyway. */
>
> -int init_module(void)
> +int __init init_module(void)
> {
> int this_dev, found = 0;
When you anyway touches the driver I suggest to name the function
<module>_init, <module>_cleanup and use module_init(), module_cleanup().
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
