* Darren Hart <[email protected]> wrote:
> @@ -1543,6 +1543,17 @@ static int try_to_wake_up(task_t *p, uns
> }
> }
>
> + /*
> + * XXX Don't send RT task elsewhere unless it can preempt current
> + * XXX on other CPU. Better yet would be for awakened RT tasks to
> + * XXX examine this(and all other) CPU(s) to see what is the best
> + * XXX fit. For example there is no check here to see if the
> + * XXX currently running task can be preempted (which would be the
> + * XXX ideal case).
> + */
> + if (rt_task(p) && !TASK_PREEMPTS_CURR(p, rq))
> + goto out_set_cpu;
> +
Great testcase! Note that we already do RT-overload wakeups further
below:
/*
* If a newly woken up RT task cannot preempt the
* current (RT) task then try to find another
* CPU it can preempt:
*/
if (rt_task(p) && !TASK_PREEMPTS_CURR(p, rq)) {
smp_send_reschedule_allbutself();
rt_overload_wakeup++;
}
what i think happened is that the above logic misses the case you have
described in detail, and doesnt mark the current CPU for rescheduling.
I.e. it sends an IPI to all _other_ CPUs, including the 'wrong target' -
but it doesnt mark the current CPU for reschedule - hence if the current
CPU is the only right target we might fail to handle this task!
could you try the (untested) patch below, does it solve your testcase
too?
Ingo
Index: linux-rt.q/kernel/sched.c
===================================================================
--- linux-rt.q.orig/kernel/sched.c
+++ linux-rt.q/kernel/sched.c
@@ -1587,11 +1587,15 @@ out_set_cpu:
} else {
/*
* If a newly woken up RT task cannot preempt the
- * current (RT) task then try to find another
- * CPU it can preempt:
+ * current (RT) task (on a target runqueue) then try
+ * to find another CPU it can preempt:
*/
if (rt_task(p) && !TASK_PREEMPTS_CURR(p, rq)) {
smp_send_reschedule_allbutself();
+ /*
+ * Trigger a reschedule check on the current CPU too:
+ */
+ set_tsk_need_resched(current);
rt_overload_wakeup++;
}
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
