Re: [NFS] [PATCH] NFS server does not update mtime on setattr request

[Neil Brown <neilb@suse.de>]

On Wednesday June 7, staubach@redhat.com wrote:
> 
> Neil, can we get these changes integrated, please?

Nope.
The discussion has already gone on from here, so I might be covering
old ground, but there seem to be further mentions of still needing the
server patch, so just to be sure it is covered....

My reading of SUS says that 
  open(O_TRUNC) of an empty file does not update the modify time
  truncate() of an empty file does update the modify time

So the server has to be able to support this distinction without being
able to directly know what API call was made on the client.
The patch you suggest makes it impossible to support that distinction.

Possibly the server could make a distinction between when nfsd_setattr
is called directly, and when it is called via nfsd_create{,_v3}.  I
would be more open to a patch that makes a distinction there.  However
I think that it would be best for the client to be explicit about what
it is doing by setting the right attr flags.

NeilBrown

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/