Re: [PATCH 1/4] Twofish cipher - split out common c code

[Herbert Xu <herbert@gondor.apana.org.au>]

On Thu, Jun 08, 2006 at 09:20:04AM +0200, Joachim Fritschi wrote:
> 
> Solve the naming conflict when compiling. Seemed to me like it is impossible to create a
> twofish.o out of twofish.o and twofish_common.o . And since having the original module name
> seemed more important to me i changed the name. I didn't find any other way in documentation
> of the kernel makefiles. I hope this isn't another newbie mistake. =)

Just make a module out of the common code.  See sound/isa/sb/Makefile
for an example.  It would also help to make a common Kconfig symbol
that is not visible to the user but instead is selected by any one
of the twofish implementations.

If you do it this way then the assembly implementations just need to
select that Kconfig symbol to get the common code either built as a
module or compiled in.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/