On Mon, 5 Jun 2006, Joachim Fritschi wrote:
> Here are the outputs from the tcrypt speedtests. They haven't changed much
> since the last patch:
>
> http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-c-i586.txt
> http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-asm-i586.txt
> http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-c-x86_64.txt
> http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-asm-x86_64.txt
when you quote anything related to cpu performance on an x86 processor
it's absolutely essential to indicate which cpu it is... basically
vendor_id, cpu family, and model from /proc/cpuinfo. (for example the
entire p4 family has incredible model-to-model variation on things like
shifts and extensions.)
> > > +/* Defining a few register aliases for better reading */
> >
> > Maybe you can read it now better, but for everybody else it is extremly
> > confusing. It would be better if you just used the original register names.
i'd change the comment to:
/* define a few register aliases to simplify macro substitution */
because as you mention, it's totally impossible to write the macros
otherwise. (i've used the same trick myself a bunch of times.)
-dean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
