Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

On Sunday 04 June 2006 15:16, Joachim Fritschi wrote:
> This patch adds the twofish x86_64 assembler routine.
>
> Changes since last version:
> - The keysetup is now handled by the twofish_common.c (see patch 1 )
> - The last round of the encrypt/decrypt routines where optimized saving 5
> instructions.
>
> Correctness was verified with the tcrypt module and automated test scripts.

Do you have some benchmark numbers that show that it's actually worth
it?

> +/* Defining a few register aliases for better reading */

Maybe you can read it now better, but for everybody else it is extremly 
confusing. It would be better if you just used the original register names.

-andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/4] Twofish cipher - x86_64 assembler
    • From: Joachim Fritschi <[email protected]>
  • Re: [PATCH 4/4] Twofish cipher - x86_64 assembler
    • From: Dag Arne Osvik <[email protected]>

• References:
  • [PATCH 4/4] Twofish cipher - x86_64 assembler
    • From: Joachim Fritschi <[email protected]>

• Prev by Date: [PATCH] ftdi_sio patch
• Next by Date: Re: [minor fix] radixtree: regulate tag get return value
• Previous by thread: [PATCH 4/4] Twofish cipher - x86_64 assembler
• Next by thread: Re: [PATCH 4/4] Twofish cipher - x86_64 assembler
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]