Re: [PATCH] readahead: initial method - expected read size - fix fastcall

On Sun, 4 Jun 2006 15:34:15 +0800
Fengguang Wu <[email protected]> wrote:

> Remove 'fastcall' directive for function readahead_close().
> 
> It has drawn concerns from Andrew Morton.

Well.  I think fastcall is ugly and vaguely silly.  Now if we has a
really_really_fastcall then I'd like to use that!


> Now I have some benchmarks
> on it, and proved it as a _false_ optimization.

Sorry, I don't believe this will be measurable (and with CONFIG_REGPARM
it'll be a no-op).

But I'm always glad to see a fastcall disappear ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] readahead: call scheme - fix fastcall readahead_cache_hit()
    • From: Fengguang Wu <[email protected]>
  • Re: [PATCH] readahead: initial method - expected read size - fix fastcall
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [RFC] Per-architecture randomization
• Next by Date: Re: [PATCH 2/5] ide: add cpu cache flushes after kmapping and modifying a page
• Previous by thread: [ANNOUNCE qgit-1.3]
• Next by thread: Re: [PATCH] readahead: initial method - expected read size - fix fastcall
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]