Re: [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives

Hi!

> >>From: Catalin Marinas <[email protected]>
> >>+		memleak_debug_not_leak(res);
> > 
> > I'd suggest some shorter/more generic name.
> > 
> > 	not_freed(res); ?
> > 
> > 	alloc_forever(res); ?
> 
> It's true that the names are a bit long ("debug" is even superfluous). I
> would, however, keep the memleak_ prefix as I think it makes the code
> clearer (i.e. the function belongs to a certain part of the kernel).

Well, in future some other leak detector may want to use these hooks.

Anyway memleak_not_leak() is already quite good.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.4
    • From: Catalin Marinas <[email protected]>
  • [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives
    • From: Catalin Marinas <[email protected]>
  • Re: [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives
    • From: Pavel Machek <[email protected]>
  • Re: [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives
    • From: Catalin Marinas <[email protected]>

• Prev by Date: Re: [PATCH] ocfs2: dereference before NULL check in ocfs2_direct_IO_get_blocks()
• Next by Date: Re: [patch 4/5] [PREEMPT_RT] Changing interrupt handlers from running in thread to hardirq and back runtime.
• Previous by thread: Re: [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives
• Next by thread: [PATCH 2.6.17-rc5 8/8] Simple testing for kmemleak
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]