RE: [patch] fix smt nice lock contention and optimization

["Chen, Kenneth W" <kenneth.w.chen@intel.com>]

Ingo Molnar wrote on Saturday, June 03, 2006 12:58 AM
> * Con Kolivas <kernel@kolivas.org> wrote:
> 
> > Could we make this neater with extra braces such as:
> > 
> >  	for_each_domain(this_cpu, tmp) {
> > 		if (tmp->flags & SD_SHARE_CPUPOWER) {
> >  			sd = tmp;
> > 			break;
> > 		}
> > 	}
> > 
> > and same for the other uses of for_each ? I know it's redundant but 
> > it's neater IMO when there are multiple lines of code below it.
> 
> yep, that's the preferred style when there are multiple lines below a 
> loop.


OK, thanks for the tips.  Here is an incremental coding-style fix:

--- ./kernel/sched.c.orig	2006-06-02 23:54:11.000000000 -0700
+++ ./kernel/sched.c	2006-06-02 23:55:45.000000000 -0700
@@ -2973,11 +2973,12 @@
 	struct sched_domain *tmp, *sd = NULL;
 	int i;
 
-	for_each_domain(this_cpu, tmp)
+	for_each_domain(this_cpu, tmp) {
 		if (tmp->flags & SD_SHARE_CPUPOWER) {
 			sd = tmp;
 			break;
 		}
+	}
 	if (!sd)
 		return;
 
@@ -3019,11 +3020,12 @@
 	if (!p->mm || rt_task(p))
 		return 0;
 
-	for_each_domain(this_cpu, tmp)
+	for_each_domain(this_cpu, tmp) {
 		if (tmp->flags & SD_SHARE_CPUPOWER) {
 			sd = tmp;
 			break;
 		}
+	}
 	if (!sd)
 		return 0;
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/