On Sat, 2006-06-03 at 01:21 +0200, Stefan Richter wrote: > Ben Collins wrote: > > Rather it be in the config. Plus your suggestion still makes it > > unusable :) > > Right. But only if ohci1394 is loaded with phys_dma=0 or a controller > without phys DMA is used. Only these conditions let sbp2 run into the > routine which currently uses bus_to_virt. Sure, that's not a problem. I just don't think we should make the option available on platforms where it cannot work at all. No need to add to the confusion. > Would '&& (X86_32 || PPC_32)' work too? Perfect. -- Ubuntu - http://www.ubuntu.com/ Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ SwissDisk - http://www.swissdisk.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 2.6.17-rc5-mm2 00/18] ieee1394: misc updates
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 01/18] video1394: be quiet
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 02/18] ohci1394.c: function calls without effect
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 03/18] sbp2: make TSB42AA9 workaround specific to Momobay CX-1
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 04/18] Semaphore to mutex conversion.
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 05/18] raw1394: fix whitespace after x86_64 compat patch
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 06/18] ieee1394/ohci1394: CycleTooLong interrupt management
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 07/18] ieee1394: support for slow links or slow 1394b phy ports
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 08/18] ieee1394: save RAM by using a single tlabel for broadcast transactions
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 09/18] sbp2: remove manipulation of inquiry response
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 10/18] sbp2: log number of supported concurrent logins
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 11/18] ieee1394: extend lowlevel API for address range properties
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 12/18] ohci1394: set address range properties
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 13/18] ohci1394: make phys_dma parameter read-only
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 14/18] sbp2: sbp2 remove ohci1394 specific constant
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 15/18] sbp2: fix S800 transfers if phys_dma is off
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 16/18] Update feature removal of obsolete raw1394 ISO requests.
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental
- From: Stefan Richter <[email protected]>
- Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental
- From: Ben Collins <[email protected]>
- Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental
- From: Stefan Richter <[email protected]>
- Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental
- From: Ben Collins <[email protected]>
- Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental
- From: Stefan Richter <[email protected]>
- [PATCH 2.6.17-rc5-mm2 00/18] ieee1394: misc updates
- Prev by Date: Re: [ckrm-tech] [RFC 3/5] sched: Add CPU rate hard caps
- Next by Date: Re: [PATCH RFC] smt nice introduces significant lock contention
- Previous by thread: Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental
- Next by thread: [PATCH 00/11] -stable review
- Index(es):
 |