Re: 2.6.17-rc5-mm1

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Thu, 1 Jun 2006, Ingo Molnar wrote:

Ingo, it would be nice to get any kind of feedback, this is already the 
third and you continue to produce more Kconfig mess, instead of fixing the 
stuff I already pointed out. :(

> Index: linux/lib/Kconfig.debug
> ===================================================================
> --- linux.orig/lib/Kconfig.debug
> +++ linux/lib/Kconfig.debug
> @@ -54,6 +54,15 @@ config DEBUG_KERNEL
>  	  Say Y here if you are developing drivers or trying to debug and
>  	  identify kernel problems.
>  
> +config DEBUG_KERNEL_OVERHEAD
> +	bool "Enable new debug options by default"
> +	default y
> +	help
> +	  Say Y here if you want to have new debugging options
> +	  enabled by default even if they cause runtime overhead.
> +	  (you can still disable/enable them manually, independently
> +	   of this switch)
> +
>  config LOG_BUF_SHIFT
>  	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)" if DEBUG_KERNEL
>  	range 12 21
> @@ -113,7 +122,7 @@ config DEBUG_SLAB
>  config DEBUG_SLAB_LEAK
>  	bool "Slab memory leak debugging"
>  	depends on DEBUG_SLAB
> -	default y
> +	default y if DEBUG_KERNEL_OVERHEAD
>  	help
>  	  Enable /proc/slab_allocators - provides detailed information about
>  	  which parts of the kernel are using slab objects.  May be used for

This is nonsense.
If you do this do it at least correctly, e.g. something like:

config DEBUG_RUNTIME_CHECKS
	bool "Enable runtime debug checks"

config DEBUG_RUNTIME_CHECKS_ALL
	bool "Enable all runtime debug checks"
	depends on DEBUG_RUNTIME_CHECKS

config DEBUG_KERNEL
	bool "Kernel debugging"

...

config DEBUG_FOO
	bool "foo" if DEBUG_KERNEL
	default DEBUG_RUNTIME_CHECKS

Your current defaults are definitively NACKed for mainline, keep them 
separate!

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/