Re: [PATCH 1/2] iWARP Connection Manager.

On Wed, 2006-05-31 at 12:24 -0700, Roland Dreier wrote:
> > > +	cm_id_priv = kzalloc(sizeof *cm_id_priv, GFP_KERNEL);
> 
> > Please put paren's after sizeof, it is not required by C but it
> > is easier to read.
> 
> I disagree -- I hate seeing sizeof look like a function call.
> 

For the most part, drivers/infiniband/core uses sizeof without
parentheses.  So I think the correct answer here is to keep the iwcm.c
file in line with the rest of the core.


Steve.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] iWARP Connection Manager.
    • From: Stephen Hemminger <[email protected]>

• References:
  • [PATCH 0/2][RFC] iWARP Core Support
    • From: Steve Wise <[email protected]>
  • [PATCH 1/2] iWARP Connection Manager.
    • From: Steve Wise <[email protected]>
  • Re: [PATCH 1/2] iWARP Connection Manager.
    • From: Stephen Hemminger <[email protected]>
  • Re: [PATCH 1/2] iWARP Connection Manager.
    • From: Roland Dreier <[email protected]>

• Prev by Date: OOPS! RE: Sharing memory between user and kernel space
• Next by Date: Re: linux-2.6 x86_64 kgdb issue
• Previous by thread: Re: [PATCH 1/2] iWARP Connection Manager.
• Next by thread: Re: [PATCH 1/2] iWARP Connection Manager.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]