Re: [Patch] statistics infrastructure - update 1

>  	case CPU_UP_PREPARE:
>  		stat->pdata->ptrs[cpu] = statistic_alloc_ptr(stat, GFP_ATOMIC,

Why not GFP_KERNEL?

> +		if (!stat->pdata->ptrs[cpu])
> +			return -ENOMEM;

NOTIFY_BAD instead of -ENOMEM, I guess.

>  		break;
>  	case CPU_UP_CANCELED:
>  	case CPU_DEAD:

I think your merge code (which gets called if CPU_UP_PREPARE fails) expects
stat->pdata->ptrs[cpu] to be non-zero, right?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Patch] statistics infrastructure - update 1
    • From: Martin Peschke <[email protected]>

• References:
  • [Patch 5/6] statistics infrastructure
    • From: Martin Peschke <[email protected]>
  • Re: [Patch 5/6] statistics infrastructure
    • From: Andrew Morton <[email protected]>
  • [Patch] statistics infrastructure - update 1
    • From: Martin Peschke <[email protected]>

• Prev by Date: Re: [PATCH 1/3] mm: tracking shared dirty pages
• Next by Date: Re: usb-serial ipaq kernel problem
• Previous by thread: [Patch] statistics infrastructure - update 1
• Next by thread: Re: [Patch] statistics infrastructure - update 1
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]