[PATCH][trivial] Clean up 'inline is not at beginning' warnings for usb storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Usually we don't care much about 'gcc -W' warnings, but some of us do build
kernels that way to look for problems, and then the fewer warnings we have 
to wade through the better. Especially when they are very easy and 
non-intrusive to clean up. Which is the case for the following warnings 
spewed by drivers/usb/storage/usb.h :

  drivers/usb/storage/usb.h:163: warning: `inline' is not at beginning of declaration
  drivers/usb/storage/usb.h:166: warning: `inline' is not at beginning of declaration

There's also some precedence for cleaning up these warnings. I've had 
a few patches merged in the past that remove exactly this class of 
warnings.

Please consider merging.


Signed-off-by: Jesper Juhl <[email protected]>
---

 drivers/usb/storage/usb.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.17-rc5-git3-orig/drivers/usb/storage/usb.h	2006-05-27 13:59:08.000000000 +0200
+++ linux-2.6.17-rc5-git3/drivers/usb/storage/usb.h	2006-05-28 18:43:26.000000000 +0200
@@ -160,10 +160,10 @@
 };
 
 /* Convert between us_data and the corresponding Scsi_Host */
-static struct Scsi_Host inline *us_to_host(struct us_data *us) {
+static inline struct Scsi_Host *us_to_host(struct us_data *us) {
 	return container_of((void *) us, struct Scsi_Host, hostdata);
 }
-static struct us_data inline *host_to_us(struct Scsi_Host *host) {
+static inline struct us_data *host_to_us(struct Scsi_Host *host) {
 	return (struct us_data *) host->hostdata;
 }
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux