Re: [ PATCH ] Longhaul - call suspend(PMSG_FREEZE) before and resume() after

[Rafa? Bilski <rafalbilski@interia.pl>]

> This is an horrible hack that breaks so many defined semantics that it's
> not even funny.

> If you want something like that, then you need to freeze/resume _all_
> devices with the proper ordering defined by the bus linkage. It has a
> number of side effects though, can't be done that easily. Maybe cpufreq
> should have the necessary infrastructure for that ?

> That's the wrong approach. If you need to stop
> DMA's during the frequency change, you either need to fix all drivers to
> register cpufreq notifiers that do so (ick !) or if you want to reuse
> the PM callbacks, you need to respect their semantics, notably vs. call
> ordering, or very bad things will happen.

> If we want to go that way, we probably need to add a bit of
> infrastructure to cpufreq to cooperate with the PM code to trigger a
> "light" machine suspend/resume, though expect delays and artifacts, it's
> not something that code be done lightly.

> Ben.

I'm toys salesman. I don't think that I'm capable.
There is already necessary infrastructure (PM). I can do freeze for all 
devices with just one function call. Problem is that only block devices 
implement freeze. Most devices do suspend insteed of freeze. Some 
devices (Speedtouch) don't implement suspend/resume. After USB power 
down You have to unplug modem.
Block devices are at top level? If I remove PCI suspend/resume 
(network card compatible) will this be OK? Other subsystems 
are visible. Can block subsystem be visible too?


> But you should really add that preempt_disable and not try this on smp
> system...
	
> Pavel

Datasheet for my C3 Nehemiah says that this processor don't have local 
APIC and is not SMP capable. I have assumed (based on original longhaul.c) 
that all VIA C3 are not SMP capable.

Would You consider appling part of this patch if I add all my assumptions
to Kconfig?

depends on EXPERIMENTAL && (HZ_100 || HZ_250) && (PREEMPT_NONE || PREEMPT_VOLUNTARY)

Rafal


----------------------------------------------------------------------
Potrzebujesz gotowki? Halogotowka to nawet 50 000 bez wizyty w banku.
Rata od 35 zl, bez poreczycieli. Wypelnij formularz. Oddzwonimy.
>>> http://link.interia.pl/f1942

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/