Re: [RFC 3/5] sched: Add CPU rate hard caps

[Peter Williams <pwil3058@bigpond.net.au>]

Kari Hurtta wrote:
> Peter Williams <pwil3058@bigpond.net.au> writes in gmane.linux.kernel:
>
> > This patch implements hard CPU rate caps per task as a proportion of a
> > single CPU's capacity expressed in parts per thousand.
>
> > + * Require: 1 <= new_cap <= 1000
> > + */
> > +int set_cpu_rate_hard_cap(struct task_struct *p, unsigned int new_cap)
> > +{
> > +	int is_allowed;
> > +	unsigned long flags;
> > +	struct runqueue *rq;
> > +	int delta;
> > +
> > +	if (new_cap > 1000 && new_cap > 0)
> > +		return -EINVAL;
>
> That condition looks wrong.

It certainly does.

Thanks
Peter
--
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/