Re: [PATCH -rt 2/2] Fix condition in default_idle

* Steven Rostedt <[email protected]> wrote:

> The condition statement in default_idle had the conjunctions 
> backwards. Instead of && it had || so the idle thread would never be 
> preempted.

> -	while (!need_resched() || !need_resched_delayed()) {
> +	while (!need_resched() && !need_resched_delayed()) {
>  		local_irq_disable();
> -		if (!need_resched() || !need_resched_delayed())
> +		if (!need_resched() && !need_resched_delayed())

doh! Good catch - applied.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH -rt 0/2] Get x86_64 running with PREEMPT_RT
    • From: Steven Rostedt <[email protected]>
  • [PATCH -rt 2/2] Fix condition in default_idle
    • From: Steven Rostedt <[email protected]>

• Prev by Date: Re: [PATCH -rt 1/2] Dont blindly turn on interrupts in boot_override_clocksource
• Next by Date: Re: [PATCH 2.6.17-rc4 1/6] Base support for kmemleak
• Previous by thread: [PATCH -rt 2/2] Fix condition in default_idle
• Next by thread: Re: [PATCH -rt 0/2] Get x86_64 running with PREEMPT_RT
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]